Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13654#discussion_r66961307
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -69,13 +73,13 @@ private[ui] class ExecutorsPage(
}
val execInfo = activeExecutorInfo ++ deadExecutorInfo
- val execInfoSorted = execInfo.sortBy(_.id)
+ val execInfoSorted = execInfo.sortWith((a, b) => strToInt(a.id) >
strToInt(b.id))
--- End diff --
I think I'd use `Ordering` trait instead as it's not very easy to spot what
the ordering is.
```
case class Info(id: String)
val infos = Seq(Info("5"), Info("driver"), Info("1"), Info("10"),
Info("500"))
implicit val onString = Ordering[Int].on((s: String) =>
util.Try(s.toInt).getOrElse(-1))
infos.sortBy(_.id)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
