Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13718#discussion_r67971887
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
 ---
    @@ -120,7 +120,13 @@ class FileStreamSource(
         val catalog = new ListingFileCatalog(sparkSession, globbedPaths, 
options, Some(new StructType))
         val files = catalog.allFiles().map(_.getPath.toUri.toString)
         val endTime = System.nanoTime
    -    logInfo(s"Listed ${files.size} in ${(endTime.toDouble - startTime) / 
1000000}ms")
    +    val listingTimeMs = (endTime.toDouble - startTime) / 1000000
    +    if (listingTimeMs > 2000) {
    +      // Output a warning when listing files uses more than 2 seconds.
    +      logWarning(s"Listed ${files.size} file(s) in $listingTimeMs ms")
    --- End diff --
    
    Should some kind of metric be introduced so that the user doesn't need to 
examine logs ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to