Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/13838#discussion_r68086736
--- Diff: R/pkg/R/sparkR.R ---
@@ -392,47 +392,81 @@ sparkR.session <- function(
#' Assigns a group ID to all the jobs started by this thread until the
group ID is set to a
#' different value or cleared.
#'
-#' @param sc existing spark context
#' @param groupid the ID to be assigned to job groups
#' @param description description for the job group ID
#' @param interruptOnCancel flag to indicate if the job is interrupted on
job cancellation
#' @examples
#'\dontrun{
-#' sc <- sparkR.init()
-#' setJobGroup(sc, "myJobGroup", "My job group description", TRUE)
+#' sparkR.session()
+#' setJobGroup("myJobGroup", "My job group description", TRUE)
#'}
#' @note setJobGroup since 1.5.0
-setJobGroup <- function(sc, groupId, description, interruptOnCancel) {
+#' @method setJobGroup default
+setJobGroup.default <- function(groupId, description, interruptOnCancel) {
+ sc <- getSparkContext()
callJMethod(sc, "setJobGroup", groupId, description, interruptOnCancel)
}
+setJobGroup <- function(sc, groupId, description, interruptOnCancel) {
+ if (class(sc) == "jobj" && any(grepl("JavaSparkContext",
getClassName.jobj(sc)))) {
+ .Deprecated("setJobGroup(groupId, description, interruptOnCancel)",
+ old = "setJobGroup(sc, groupId, description,
interruptOnCancel)")
+ setJobGroup.default(groupId, description, interruptOnCancel)
+ } else {
+ # Parameter order is shifted
--- End diff --
Would it be cleaner to name the variables differently ? Something like
`groupIdToUse <- sc` etc.
Also just curious -- what are the semantics of calling a 4 argument
function with just 3 arguments in S3 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
