Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13760#discussion_r68268602
  
    --- Diff: R/pkg/R/group.R ---
    @@ -199,17 +199,10 @@ createMethods()
     #' Applies a R function to each group in the input GroupedData
     #'
     #' @param x a GroupedData
    -#' @param func A function to be applied to each group partition specified 
by GroupedData.
    -#'             The function `func` takes as argument a key - grouping 
columns and
    -#'             a data frame - a local R data.frame.
    -#'             The output of `func` is a local R data.frame.
    -#' @param schema The schema of the resulting SparkDataFrame after the 
function is applied.
    -#'               The schema must match to output of `func`. It has to be 
defined for each
    -#'               output column with preferred output column name and 
corresponding data type.
    -#' @return a SparkDataFrame
     #' @rdname gapply
     #' @name gapply
     #' @export
    +#' @seealso \link{gapplyCollect}
     #' @examples
     #' \dontrun{
    --- End diff --
    
    I think its fine either way (to have the examples spread vs. not spread). 
BTW the snippet pasted above looks pretty good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to