Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/13839#discussion_r68317336
--- Diff: R/pkg/R/DataFrame.R ---
@@ -177,8 +177,8 @@ setMethod("isLocal",
#' @param x A SparkDataFrame
#' @param numRows The number of rows to print. Defaults to 20.
#' @param truncate Whether truncate long strings. If true, strings more
than 20 characters will be
-#' truncated and all cells will be aligned right
-#'
+#' truncated. However, if set greater than zero, truncates strings
longer than `truncate`
--- End diff --
Code change looks fine. Can we add a R unit test as well ? We could just
add another test similar to
https://github.com/ScrapCodes/spark/blob/daab62a4f3fa8515fbe3d787e489abbc69370628/R/pkg/inst/tests/testthat/test_sparkSQL.R#L1578
but with say `truncate=3`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
