Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13912#discussion_r68506352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala
---
@@ -195,18 +202,50 @@ private[sql] class CsvOutputWriter(
private var records: Long = 0L
private val csvWriter = new LineCsvWriter(params,
dataSchema.fieldNames.toSeq)
- private def rowToString(row: Seq[Any]): Seq[String] = row.map { field =>
- if (field != null) {
- field.toString
- } else {
- params.nullValue
+ private def rowToString(row: InternalRow): Seq[String] = {
+ var i = 0
+ val values = new Array[String](row.numFields)
+ while (i < row.numFields) {
--- End diff --
Please use `values.indices` and then `map` or `foreach` to make it more
functional (and hopefully readable). With the change, you'll link `values` to
indices (not relying on `row.numFields` used twice).
BTW, do we need `values` to be initialized first before adding elements?
I'd vote for `foldLeft` as a better alternative, e.g.
```
def appendRowValue(arr: Array[String], i: Int) = {
// do the if here
arr
}
(0 to row.numFields).foldLeft(Array[String]()) { case (arr, i) => arr }
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
