Github user koertkuipers commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13727#discussion_r68624316
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
    @@ -135,7 +129,7 @@ class DataFrameReader private[sql](sparkSession: 
SparkSession) extends Logging {
        * @since 1.4.0
        */
       def load(path: String): DataFrame = {
    -    option("path", path).load()
    +    load(Seq(path): _*) // force invocation of `load(...varargs...)`
    --- End diff --
    
    with this change path is no longer available in the options. this makes it 
hard (impossible?) for non-file based DataSources (not implementing FileFormat) 
to use load(...)
    
    For example for elasticsearch we use:
    ```
    sqlContext.read.format("org.elasticsearch.spark.sql").load(resource)
    ```
    i do not think this can be implemented anymore now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to