GitHub user yinxusen opened a pull request:

    https://github.com/apache/spark/pull/14006

    [SPARK-13015][MLlib][DOC] Replace example code in mllib-data-types.md using 
include_example

    ## What changes were proposed in this pull request?
    
    1. Add more specific error prompt for include_example.rb
    2. Replace example code in mllib-data-types.md using include_example
    
    For Scala/Python code, I add imports inside each function, which is easy to 
control those codes. Java import doesn't support that, so I leave them with 
duplications.
    
    BTW The `tallSkinnyQR` in both Scala and Java failed when I ran the code. 
I'll look into them soon.
    
    ## How was this patch tested?
    
    Tested manually by running new example code, and generating docs with 
jekyll build.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yinxusen/spark SPARK-13015-consolidate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14006
    
----
commit 4fa23b4fb74e252bc9b8cd9cda0f1453752639bd
Author: Xusen Yin <yinxu...@gmail.com>
Date:   2016-06-30T19:02:43Z

    add scala example and fix error prompt in include_example

commit 5ce1ef1948434162961139222d23ff3bd7fa2b8b
Author: Xusen Yin <yinxu...@gmail.com>
Date:   2016-06-30T21:40:58Z

    change md file

commit 922ba78801549a801d3f9567bbb065e6ba7fd0d5
Author: Xusen Yin <yinxu...@gmail.com>
Date:   2016-06-30T21:41:31Z

    refine modifier

commit b0e74e34accd768d2d16e4afc41d46a7cde4da8b
Author: Xusen Yin <yinxu...@gmail.com>
Date:   2016-06-30T22:32:30Z

    add sc

commit 51018c96f5329c6bdd7c550456f936d26c5b13c7
Author: Xusen Yin <yinxu...@gmail.com>
Date:   2016-06-30T23:02:32Z

    fix java imports

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to