Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69251673
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class StringRPad(str: Expression, len:
Expression, pad: Expression)
}
/**
+ * Extracts a part from a URL
+ */
+@ExpressionDescription(
+ usage = "_FUNC_(url, partToExtract[, key]) - extracts a part from a URL",
+ extended = "Parts: HOST, PATH, QUERY, REF, PROTOCOL, AUTHORITY, FILE,
USERINFO\n"
+ + "key specifies which query to extract\n"
+ + "Examples:\n"
+ + " > SELECT _FUNC_('http://spark.apache.org/path?query=1', "
+ + "'HOST') FROM src LIMIT 1;\n" + " 'spark.apache.org'\n"
+ + " > SELECT _FUNC_('http://spark.apache.org/path?query=1', "
+ + "'QUERY') FROM src LIMIT 1;\n" + " 'query=1'\n"
+ + " > SELECT _FUNC_('http://spark.apache.org/path?query=1', "
+ + "'QUERY', 'query') FROM src LIMIT 1;\n" + " '1'")
+case class ParseUrl(children: Expression*)
--- End diff --
The parameter `key` can only be present when `partToExtract` is `QUERY`. So
there are two parameters call and three parameters call. I have not figured out
a better way to accomplish this.
I'll keep on trying to do it better. If there is any advice, that will be
very helpful. Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
