Github user jjthomas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13957#discussion_r69358134
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -136,7 +149,8 @@ class TextSocketSourceProvider extends
StreamSourceProvider with DataSourceRegis
parameters: Map[String, String]): Source = {
val host = parameters("host")
val port = parameters("port").toInt
- new TextSocketSource(host, port, sqlContext)
+ new TextSocketSource(host, port,
+ parameters.getOrElse("includeTimestamp", "false").toBoolean,
sqlContext)
--- End diff --
sourceSchema and createSource are separate functions that are passed the
parameters map, so the conversion to Boolean needs to happen in both places.
Think it's fine if this throws an error if it's not parseable ... the line
above will also throw an error if "port" is not parseable as Int.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
