GitHub user wangmiao1981 opened a pull request:

    https://github.com/apache/spark/pull/14021

    [SPARK-16260][ML][Example]:PySpark ML Example Improvements and Cleanup

    ## What changes were proposed in this pull request?
    1). Remove unused import in Scala example;
    
    2). Move spark session import outside example off;
    
    3). Change parameter setting the same as Scala;
    
    4). Change comment to be consistent;
    
    5). Make sure that Scala and python using the same data set;
    
    I did one pass and fixed the above issues. There are missing examples in 
python, which might be added later.
    
    TODO: For some examples, there are comments on how to run examples; But 
there are many missing. We can add them later.
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)
    
    Manually test them


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangmiao1981/spark ann

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14021
    
----
commit c95d4e408b4f4ffa5f1d6631a286637d39f3d183
Author: wm...@hotmail.com <wm...@hotmail.com>
Date:   2016-07-01T22:47:31Z

    fix examples

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to