Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13517#discussion_r69380919
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,11 +45,11 @@ statement
| ALTER DATABASE identifier SET DBPROPERTIES tablePropertyList
#setDatabaseProperties
| DROP DATABASE (IF EXISTS)? identifier (RESTRICT | CASCADE)?
#dropDatabase
| createTableHeader ('(' colTypeList ')')? tableProvider
- (OPTIONS tablePropertyList)?
+ (OPTIONS optionParameterList)?
(PARTITIONED BY partitionColumnNames=identifierList)?
bucketSpec?
#createTableUsing
| createTableHeader tableProvider
- (OPTIONS tablePropertyList)?
--- End diff --
@HyukjinKwon I am on holiday - so I am bit slow with my responses.
Yo have understood me correctly. What I am suggesting will affect the
DBPROPERTIES and TBLPROPERTIES; it will also allow for boolean and numeric
options. I don't think this is a bad thing, it is better to have a lenient
parser and to constrain behavior in the `AstBuilder` (this allows us to throw
much better error messages).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
