Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/13532#discussion_r69397207
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -305,4 +305,13 @@ class DatasetAggregatorSuite extends QueryTest with
SharedSQLContext {
val ds = Seq(1, 2, 3).toDS()
checkDataset(ds.select(MapTypeBufferAgg.toColumn), 1)
}
+
+ test("spark-15204 improve nullability inference for Aggregator") {
+ val ds1 = Seq(1, 3, 2, 5).toDS()
+ assert(ds1.select(typed.sum((i: Int) => i)).schema.head.nullable ===
false)
+ val ds2 = Seq(AggData(1, "a"), AggData(2, "a")).toDS()
+ assert(ds2.groupByKey(_.b).agg(SeqAgg.toColumn).schema(1).nullable ===
true)
--- End diff --
the last assert with NameAgg tests String as output of the Aggregator. is
that good enough?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
