Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69400465
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -55,7 +56,7 @@ class LogisticRegressionSuite
generateMultinomialLogisticInput(coefficients, xMean, xVariance,
addIntercept = true, nPoints, 42)
- spark.createDataFrame(sc.parallelize(testData, 4))
+ sc.parallelize(testData, 4).toDF()
--- End diff --
I guess, to be strict, `sc.parallelize(testData, 4).toDF()` and
`testData.toDF.repartition(4)` would not be exactly the same. It seems the
author of this test code intended to explicitly set the initial number of
partitions to `4` and I left as it is although I think as you said because I am
not 100% sure and it is not the part of this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
