Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13981#discussion_r69410553
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
 ---
    @@ -96,6 +108,15 @@ class DecisionTreeRegressorSuite
           assert(variance === expectedVariance,
             s"Expected variance $expectedVariance but got $variance.")
         }
    +
    +    val toyDF = TreeTests.setMetadata(toyData, Map.empty[Int, Int], 0)
    +    dt.setMaxDepth(1)
    +      .setMaxBins(6)
    --- End diff --
    
    I'd like to remove the explicit setting since the default value(32) meets 
your needs. We want to make Jenkins logging clean and reduce the number of 
warnings if possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to