Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14036#discussion_r69511190
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -237,54 +229,100 @@ case class Divide(left: Expression, right:
Expression)
}
}
+ // Used by doGenCode
+ def divide(eval1: ExprCode, eval2: ExprCode, javaType: String): String
+ def isZero(eval2: ExprCode): String
+
/**
* Special case handling due to division by 0 => null.
*/
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val eval1 = left.genCode(ctx)
val eval2 = right.genCode(ctx)
- val isZero = if (dataType.isInstanceOf[DecimalType]) {
--- End diff --
why not just keep it? Then the 2 implementations can share the same codegen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
