Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14038#discussion_r69518421
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala
 ---
    @@ -230,6 +236,15 @@ trait FileFormat {
       }
     
       /**
    +   * Return a `SerializablePathFilter` class to filter qualified files for 
this format.
    +   */
    +  def getPathFilter(): SerializablePathFilter = {
    --- End diff --
    
    Shall we add either the data source options map or the Hadoop conf as an 
argument of this method?
    
    For example, the Avro data source may filter out all input files whose file 
names don't end with ".avro" if Hadoop conf 
"avro.mapred.ignore.inputs.without.extension" is set to true. This is 
consistent with default behavior of `AvroInputFormat`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to