Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14047#discussion_r69527187
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -391,6 +391,29 @@ class HiveDDLSuite
}
}
+ test("create view with mismatched schema") {
--- End diff --
Yes. You're right. I must've overlooked this no-so-little difference. Is
`temporary` the only difference between the tests? Could we have a template
test method to generate proper versions for the case? (even if it were too much
for this change, it'd pave the way for more tests like this in the future). We
could also have a follow-up change after this one is committed. WDYT @srowen
@rxin? Is this worth the effort? I'm concerned with this duplication.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
