Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/13876
  
    Ah, in order to optimize once, `list.forall(_.deterministic)` seems not 
sufficient.
    It passes many normal cases again and again. For `OptimizeIn` optimizer 
case, we need `SQLConf`, too.
    Actually, it seems that we need a **var** flag like a transition from `In` 
to `InSet` instead of **lazy val**
    
    In other words, for `Optimize-Once` semantics,
    - First, we should give a change to enter optimizations if it's optimizable.
      So, the flag should be **initialized by each optimizer** as a `true` with 
some proper own conditions.
    - After optimization, the optimizers should **turn off the flag** to 
prevent further computation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to