Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14052#discussion_r69933155
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionServer.scala ---
@@ -93,6 +94,14 @@ private[spark] abstract class RestSubmissionServer(
contextToServlet.foreach { case (prefix, servlet) =>
mainHandler.addServlet(new ServletHolder(servlet), prefix)
}
+ if(masterConf.getBoolean("spark.rest.csrf.enable", false)) {
--- End diff --
I'm not familiar with this but the question is should the config be
documented? I assume this is something you want the end user to have the
option of using?
if this is only being used by the private Rest apis should it be true by
default or what exactly are the ramifications of that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
