Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14285#discussion_r71776630
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
 ---
    @@ -167,6 +168,21 @@ abstract class ExternalCatalog {
           table: String,
           partialSpec: Option[TablePartitionSpec] = None): 
Seq[CatalogTablePartition]
     
    +  /**
    +   * Returns partitions filtered by predicates for the given table, It 
just work for Hive.
    +   *
    +   * The filters Expressions may optionally be provided to filter the 
partitions returned.
    +   * For instance, if there exist partitions (a='1', b='2'), (a='1', 
b='3') and (a='2', b='4'),
    +   * then the filters (a='1') will return the first two only.
    +   * @param db database name
    --- End diff --
    
    New line before `@param`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to