Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14410#discussion_r73035235
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
 ---
    @@ -449,6 +449,22 @@ class DataFrameReaderWriterSuite extends QueryTest 
with SharedSQLContext with Be
         }
       }
     
    +  test("saveAsTable(CTAS) when the source DataFrame is built on a 
SimpleCatalog table") {
    +    import testImplicits._
    +
    +    val tableName = "tab1"
    +    withTable(tableName) {
    +      sql(s"CREATE TABLE $tableName(key int, value int) USING parquet")
    +      (1 to 2).map { i => (i, i) }.toDF("key", 
"value").write.insertInto(tableName)
    +      val df = sql(s"select key, value from $tableName")
    +      df.write.mode("append").saveAsTable(tableName)
    --- End diff --
    
    What do you think about using `SaveMode.Append` instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to