Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14557#discussion_r74688557
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -798,6 +798,19 @@ private[spark] class TaskSetManager(
           }
         }
         maybeFinishTaskSet()
    +
    +    // kill running task if stage failed
    +    if(reason.isInstanceOf[FetchFailed]) {
    +      killTasks(runningTasksSet, taskInfos)
    +    }
    +  }
    +
    +  def killTasks(tasks: HashSet[Long], taskInfo: HashMap[Long, TaskInfo]): 
Boolean = {
    +    tasks.foreach { task =>
    +      val executorId = taskInfo(task).executorId
    +      sched.sc.schedulerBackend.killTask(task, executorId, true)
    +    }
    +    true
    --- End diff --
    
    Why are you returning `true` if you don't use it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to