Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14680#discussion_r75073488 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala --- @@ -40,6 +40,8 @@ class TextFileFormat extends TextBasedFileFormat with DataSourceRegister { override def shortName(): String = "text" + override def toString: String = shortName.toUpperCase --- End diff -- I did see it but I'd do the opposite and rather fix JSON and CSV than repeat what's in `shortName`. I even thought about defining the `toString` in a supertype, but could find nothing that would be acceptable.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org