Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14681#discussion_r75074428
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/ui/StreamingJobProgressListenerSuite.scala
 ---
    @@ -68,6 +68,7 @@ class StreamingJobProgressListenerSuite extends 
TestSuiteBase with Matchers {
         listener.waitingBatches should be 
(List(BatchUIData(batchInfoSubmitted)))
         listener.runningBatches should be (Nil)
         listener.retainedCompletedBatches should be (Nil)
    +    listener.lastReceivedBatch should be 
(Some(BatchUIData(batchInfoSubmitted)))
    --- End diff --
    
    What do you think about `should contain (BatchUIData(batchInfoSubmitted))` 
instead? See 
http://www.scalatest.org/user_guide/using_matchers#workingWithContainers. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to