Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14720#discussion_r75601779
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -87,6 +88,9 @@ private[hive] class HiveClientImpl(
       // Circular buffer to hold what hive prints to STDOUT and ERR.  Only 
printed when failures occur.
       private val outputBuffer = new CircularBuffer()
     
    +  // An object lock to ensure URL factory is registered exactly once.
    +  object URLFactoryRegistrationLock{}
    --- End diff --
    
    Why do you need `{}`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to