Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14759#discussion_r75758122
--- Diff: R/run-tests.sh ---
@@ -26,14 +26,30 @@ rm -f $LOGFILE
SPARK_TESTING=1 $FWDIR/../bin/spark-submit --driver-java-options
"-Dlog4j.configuration=file:$FWDIR/log4j.properties" --conf
spark.hadoop.fs.default.name="file:///" $FWDIR/pkg/tests/run-all.R 2>&1 | tee
-a $LOGFILE
FAILED=$((PIPESTATUS[0]||$FAILED))
+# Also run the documentation tests for CRAN
+CRAN_CHECK_LOG_FILE=$FWDIR/cran-check.out
+rm -f $CRAN_CHECK_LOG_FILE
+CRAN_CHECK_OPTIONS="--no-tests --no-manual" $FWDIR/check-cran.sh 2>&1 |
tee -a $CRAN_CHECK_LOG_FILE
+FAILED=$((PIPESTATUS[0]||$FAILED))
+
+HAS_CRAN_WARNING="$(grep -c WARNING $CRAN_CHECK_LOG_FILE)"
--- End diff --
Good point - Added that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
