Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14759#discussion_r75781286
--- Diff: R/run-tests.sh ---
@@ -26,14 +26,35 @@ rm -f $LOGFILE
SPARK_TESTING=1 $FWDIR/../bin/spark-submit --driver-java-options
"-Dlog4j.configuration=file:$FWDIR/log4j.properties" --conf
spark.hadoop.fs.default.name="file:///" $FWDIR/pkg/tests/run-all.R 2>&1 | tee
-a $LOGFILE
FAILED=$((PIPESTATUS[0]||$FAILED))
+# Also run the documentation tests for CRAN
+CRAN_CHECK_LOG_FILE=$FWDIR/cran-check.out
+rm -f $CRAN_CHECK_LOG_FILE
+
+NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a
$CRAN_CHECK_LOG_FILE
+FAILED=$((PIPESTATUS[0]||$FAILED))
+
+NUM_CRAN_WARNING="$(grep -c WARNING$ $CRAN_CHECK_LOG_FILE)"
+NUM_CRAN_ERROR="$(grep -c ERROR$ $CRAN_CHECK_LOG_FILE)"
+NUM_CRAN_NOTES="$(grep -c NOTE$ $CRAN_CHECK_LOG_FILE)"
+
if [[ $FAILED != 0 ]]; then
cat $LOGFILE
echo -en "\033[31m" # Red
echo "Had test failures; see logs."
echo -en "\033[0m" # No color
exit -1
else
- echo -en "\033[32m" # Green
- echo "Tests passed."
- echo -en "\033[0m" # No color
+ # We have 2 existing NOTEs for new maintainer, attach()
+ # We have one more NOTE in Jenkins due to "No repository set"
+ if [[ $NUM_CRAN_WARNING != 0 || $NUM_CRAN_ERROR != 0 ||
$NUM_CRAN_NOTES -gt 3 ]]; then
--- End diff --
I think we can leave this as `3` for now to satisfy Jenkins -- It means
that if a PR is tested locally it might pass despite a new note being added,
but Jenkins should anyway catch this during code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
