Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/14761#discussion_r75797228
--- Diff: R/pkg/R/sparkR.R ---
@@ -367,19 +367,21 @@ sparkR.session <- function(
overrideEnvs(sparkConfigMap, paramMap)
}
# do not download if it is run in the sparkR shell
- if (!nzchar(master) || is_master_local(master)) {
- if (!is_sparkR_shell()) {
- if (is.na(file.info(sparkHome)$isdir)) {
+ if (!is_sparkR_shell()) {
+ if (!is.na(file.info(sparkHome)$isdir)) {
+ msg <- paste0("Spark package found in SPARK_HOME: ", sparkHome)
+ message(msg)
--- End diff --
Agree that if there exist an existing session, we shouldn't repeat the same
message. But it would be useful to have this message for the first time to help
debugging. I can imagine users hit issues due to wrong env variables or search
path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
