Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14433#discussion_r77205301
--- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
@@ -135,7 +136,12 @@ private[spark] trait Logging {
val replLevel = Option(replLogger.getLevel()).getOrElse(Level.WARN)
if (replLevel != rootLogger.getEffectiveLevel()) {
System.err.printf("Setting default log level to \"%s\".\n",
replLevel)
- System.err.println("To adjust logging level use
sc.setLogLevel(newLevel).")
+ if (SparkSubmit.isRShell) {
--- End diff --
+1 -- I personally find it odd that we would import `deploy.SparkSubmit`
into `Logging` which is a base class used throughout the code base. We could
also change the log message to be more vague. Something like `To adjust logging
level please call setLogLevel(newLevel) using SparkContext` might work for all
languages ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
