GitHub user keypointt opened a pull request:

    https://github.com/apache/spark/pull/15353

    [SPARK-17724][WebUI][Streaming] Unevaluated new lines in tooltip in DAG 
Visualization of a job

    https://issues.apache.org/jira/browse/SPARK-17724
    
    ## What changes were proposed in this pull request?
    
    Replace `\n` of RDD Node name with a space
    
    1. Since this graph node name is escaped in scala source file, I choose to 
change it at JavaScript level.
    2. I didn't change scala source file, which I'm afraid could have side 
effects.
    
    Also, I removed some unused imports and semicolons.
    
    ## How was this patch tested?
    
    Tested locally
    
    Before fix, `\n` is part of the popup tooltip:
    ![screen shot 2016-10-03 at 5 28 16 
pm](https://cloud.githubusercontent.com/assets/3925641/19097315/9a44ab32-8a58-11e6-81ad-6361d2253bb9.png)
    
    After fix, replace `\n` with a space:
    ![screen shot 2016-10-04 at 10 17 58 
am](https://cloud.githubusercontent.com/assets/3925641/19097318/a8edc9de-8a58-11e6-8c37-30271b761284.png)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/keypointt/spark SPARK-17724

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15353
    
----
commit e2e954d20eb10e18d096ad4b6f867f889fab517c
Author: Xin Ren <iamsh...@126.com>
Date:   2016-10-04T17:19:08Z

    [SPARK-17724] replace line break with a space

commit a0a74167df7571732680f7906f64430bbc2a2353
Author: Xin Ren <iamsh...@126.com>
Date:   2016-10-04T20:53:22Z

    [SPARK-17724] fix typo

commit a2f2a96bf85c844bc1925b18e13fd2cc91293efa
Author: Xin Ren <iamsh...@126.com>
Date:   2016-10-04T22:05:51Z

    [SPARK-17724] remove unused import

commit 01f8f0a81a04478bc87c7eeecd64fb4a55cf31b7
Author: Xin Ren <iamsh...@126.com>
Date:   2016-10-04T22:20:25Z

    [SPARK-17724] remove unused import

commit d6d7e4661bc05e69f0b77b7284c0ea086e66d325
Author: Xin Ren <iamsh...@126.com>
Date:   2016-10-05T00:12:21Z

    [SPARK-17724] unnecessary semicolon

commit 968f8cfd52a11d17383f7d29d8bb849906240680
Author: Xin Ren <iamsh...@126.com>
Date:   2016-10-05T00:15:09Z

    [SPARK-17724] remove unused variable

commit b078fd2c3f82c807d06d95858c2704b5023033d0
Author: Xin Ren <iamsh...@126.com>
Date:   2016-10-05T00:20:31Z

    [SPARK-17724] remove unused import

commit e50dc17ee4b243312ef4e07bb3ef2efb03a0c5b3
Author: Xin Ren <iamsh...@126.com>
Date:   2016-10-05T00:24:20Z

    [SPARK-17724] unnecessary semicolon

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to