Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15471#discussion_r84730154
  
    --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackend.scala ---
    @@ -110,6 +115,11 @@ private[spark] object RBackend extends Logging {
           val boundPort = sparkRBackend.init()
           val serverSocket = new ServerSocket(0, 1, 
InetAddress.getByName("localhost"))
           val listenPort = serverSocket.getLocalPort()
    +      // Connection timeout is set by socket client. To make it 
configurable we will pass the
    +      // timeout value to client inside the temp file
    +      val conf = new SparkConf()
    +      val backendConnectionTimeout = conf.getInt(
    --- End diff --
    
    Are we sure SparkConf has been initialized successfully at this point ? Or 
to to put it another way, in which cases does this code path get called from ? 
Is this in the `spark-submit` case or the shell etc. ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to