Github user jaceklaskowski commented on the issue:

    https://github.com/apache/spark/pull/15758
  
    Thanks @rxin for looking into it. While reviewing that code I noticed the 
call and thought I'd push it for review here since...`getBucketSpec` is 
superfluous given `assertNotBucketed("save")` at the very beginning. Correct me 
if I'm wrong (that will further help me understand the code).
    
    I don't want to push the change for this one single line and wouldn't mind 
if you could merge it with some other more important change(s). Do whatever is 
best for the code. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to