Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15593#discussion_r87267275
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -489,13 +485,14 @@ class LogisticRegression @Since("1.2.0") (
val initialCoefWithInterceptArray =
initialCoefficientsWithIntercept.toArray
--- End diff --
can you document on line 465 the layout of the data, to help future
developers (all the coefficients, in column major order, maybe followed by a
last column that contain the intercept)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
