Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/15790#discussion_r87510311
--- Diff: R/create-docs.sh ---
@@ -52,21 +52,28 @@ Rscript -e 'libDir <- "../../lib"; library(SparkR,
lib.loc=libDir); library(knit
popd
-# Find Spark jars.
-if [ -f "${SPARK_HOME}/RELEASE" ]; then
- SPARK_JARS_DIR="${SPARK_HOME}/jars"
+if [ -n "$NO_VIGNETTES" ]
+then
+ echo "Skipping R vignettes"
else
-
SPARK_JARS_DIR="${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION/jars"
-fi
-# Only create vignettes if Spark JARs exist
-if [ -d "$SPARK_JARS_DIR" ]; then
- # render creates SparkR vignettes
- Rscript -e 'library(rmarkdown); paths <- .libPaths(); .libPaths(c("lib",
paths)); Sys.setenv(SPARK_HOME=tools::file_path_as_absolute(".."));
render("pkg/vignettes/sparkr-vignettes.Rmd"); .libPaths(paths)'
+ # Find Spark jars.
--- End diff --
Yeah that seems fine to me. the `create-doc.sh` is used to generate docs
for the Spark website etc. so its probably ok to not do the vignette as a part
of that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
