Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92932104 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -964,10 +970,16 @@ object StaticSQLConf { } } + val DEFAULT_WAREHOUSE_PATH = buildConf("spark.sql.default.warehouse.dir") --- End diff -- I am not familiar with this part of the code base - What are the consequences of making it internal ? Is it just in terms of what shows up in documentation or does it affect how users can use it ?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org