Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16475
Partially agree @srowen. The reason for the change was `blockId.isShuffle`
condition that both methods use to do their shuffle-specific handling. The
change might not be the most correct one but I'm sure something's wrong here,
but can't nail it and hence the change to review this part of shuffle system.
> "is a distant problem waiting to happen"
I was concerned about that too, but that's what the tests are supposed to
cover. If there are few missing, they should be added, shouldn't they?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
