Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/16517#discussion_r96566523
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -276,40 +276,31 @@ case class InsertIntoHiveTable(
}
}
- val jobConf = new JobConf(hadoopConf)
- val jobConfSer = new SerializableJobConf(jobConf)
-
- // When speculation is on and output committer class name contains
"Direct", we should warn
- // users that they may loss data if they are using a direct output
committer.
- val speculationEnabled =
sqlContext.sparkContext.conf.getBoolean("spark.speculation", false)
- val outputCommitterClass =
jobConf.get("mapred.output.committer.class", "")
- if (speculationEnabled && outputCommitterClass.contains("Direct")) {
--- End diff --
Do we still need this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
