GitHub user admackin opened a pull request:
https://github.com/apache/spark/pull/16652
[SPARK-19234][MLLib] AFTSurvivalRegression should fail fast when any labels
are zero
## What changes were proposed in this pull request?
If any labels of 0.0 (which are invalid) are supplied,
AFTSurvivalRegression gives an error straight away rather than
hard-to-interpret warnings and zero-valued coefficients in the output.
## How was this patch tested?
Verified against current test suite. (One test needed to be updated as it
was providing values of zero for labels so was failing after this patch)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/admackin/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16652.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16652
----
commit ab6d4148c4aa721898733b14eec5068652ca1085
Author: Andy MacKinlay <a...@akmy.net>
Date: 2017-01-20T01:56:45Z
Addresses SPARK-19234 - make sure label is positive
commit b07c281c378d68d86b81498ca247c7346719973e
Author: Andy MacKinlay <a...@akmy.net>
Date: 2017-01-20T04:02:54Z
Addresses SPARK-19234 - fix test suite to ensure no zero-labels get passed
in test cases as they now throw errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
