Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16631#discussion_r97017902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -344,7 +344,8 @@ abstract class UnaryNode extends LogicalPlan {
sizeInBytes = 1
}
- child.stats(conf).copy(sizeInBytes = sizeInBytes)
+ // Don't propagate rowCount and attributeStats, since they are not
estimated here.
--- End diff --
If we remove this, estimation result of aggregate still has wrong rowCount
and attributeStats.
Shall we merge this and I'll do tests for other unaryNodes and fix them if
something still goes wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
