Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16646#discussion_r97019304
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/r/GaussianMixtureWrapper.scala ---
@@ -91,7 +92,10 @@ private[r] object GaussianMixtureWrapper extends
MLReadable[GaussianMixtureWrapp
.setStages(Array(rFormulaModel, gm))
.fit(data)
- new GaussianMixtureWrapper(pipeline, dim)
+ val gmm: GaussianMixtureModel =
pipeline.stages(1).asInstanceOf[GaussianMixtureModel]
--- End diff --
they are the same when the pipeline has 1 stage.
I prefer `stages.last` because if we later add a stage to transform the
input data it will break `stages(1)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
