Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/16685
  
    @ilganeli Regarding the support of **UPDATE**, your idea is pretty good. 
Please submit a separate PR and improve the document. I will review it. 
    
    Regarding the support of **UPSERT**, we need to measure the performance. We 
can try the both solutions and measure the performance difference. 
    
    I have a very basic question. If we are doing the **UPSERT for a small data 
set** (which is a common case), it sounds like fetching the whole table from 
the source is pretty expensive. Normally, the performance of JDBC is 
nortoriously bad when the table size is large. Thus, IMHO, we need to avoid 
fetching the source table for supporting UPSERT. 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to