Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16812#discussion_r99935349 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchemaSuite.scala --- @@ -73,6 +73,12 @@ class CSVInferSchemaSuite extends SparkFunSuite { assert(CSVInferSchema.inferField(LongType, "2015-08 14:49:00", options) == StringType) } + test("Boolean field types are inferred correctly from custom value") { + val options = new CSVOptions(Map("trueValue" -> "yes")) + assert(CSVInferSchema.inferField(BooleanType, "yES", options) == BooleanType) --- End diff -- What's the reason for `==` not `===` as it's in the other asserts?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org