Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16951#discussion_r101685081
--- Diff: R/pkg/R/stats.R ---
@@ -149,15 +149,19 @@ setMethod("freqItems", signature(x =
"SparkDataFrame", cols = "character"),
#' This method implements a variation of the Greenwald-Khanna algorithm
(with some speed
#' optimizations). The algorithm was first present in
[[http://dx.doi.org/10.1145/375663.375670
#' Space-efficient Online Computation of Quantile Summaries]] by Greenwald
and Khanna.
+#' Note that rows containing any NA values will be removed before
calculation.
#'
#' @param x A SparkDataFrame.
-#' @param col The name of the numerical column.
+#' @param cols A single column name, or a list of names for multiple
columns.
--- End diff --
typically, this would have been a breaking API parameter name change that
we should avoid, but, because of special R parameter partial matching rule of
`col` matching `cols`, this is in fact compatible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
