Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17216#discussion_r105069281
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -380,7 +382,20 @@ class StreamExecution(
logInfo(s"Resuming streaming query, starting with batch $batchId")
currentBatchId = batchId
availableOffsets = nextOffsets.toStreamProgress(sources)
- offsetSeqMetadata =
nextOffsets.metadata.getOrElse(OffsetSeqMetadata())
+ val numShufflePartitionsFromConf =
sparkSession.conf.get(SQLConf.SHUFFLE_PARTITIONS)
+ offsetSeqMetadata = nextOffsets
+ .metadata
+ .getOrElse(OffsetSeqMetadata(0, 0, numShufflePartitionsFromConf))
+
+ /*
+ * For backwards compatibility, if # partitions was not recorded
in the offset log, then
+ * ensure it is non-zero. The new value is picked up from the conf.
+ */
--- End diff --
for inline comment with the code, use // and not /* .. */.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
