Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17088#discussion_r107283229
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1331,7 +1328,20 @@ class DAGScheduler(
// TODO: mark the executor as failed only if there were lots of
fetch failures on it
if (bmAddress != null) {
- handleExecutorLost(bmAddress.executorId, filesLost = true,
Some(task.epoch))
+ val hostToUnregisterOutputs = if
(env.blockManager.externalShuffleServiceEnabled) {
+ // We had a fetch failure with the external shuffle service,
so we
+ // assume all shuffle data on the node is bad.
+ Some(bmAddress.host)
+ } else {
+ // Deregister shuffle data just for one executor (we don't
have any
--- End diff --
nit: "Unregister" is used elsewhere (function names, etc.), not
"deregister".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
