Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/17108#discussion_r107505718
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/util/TestingUtils.scala ---
@@ -32,6 +32,10 @@ object TestingUtils {
* the relative tolerance is meaningless, so the exception will be
raised to warn users.
*/
private def RelativeErrorComparison(x: Double, y: Double, eps: Double):
Boolean = {
+ // Special case for NaNs
--- End diff --
@jkbradley I do not think this change is going to be controversial, but I
want to point out that from now on, matrix/vector checks will not _always_
throw errors when comparing `NaN`: the previous code would throw whenever a NaN
was found.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
