Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17417#discussion_r108035464
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala ---
@@ -22,7 +22,7 @@ import org.apache.spark.sql.Column
import org.apache.spark.sql.catalyst.expressions._
/**
- * Utility functions for defining window in DataFrames.
+ * Utility functions for defining window in Datasets.
--- End diff --
Sure. I'm going to revert the changes. There's a little value in them. I'd
rather see the changes approved in general than fight for DataFrame vs Dataset.
p.s. There's no `DataFrame` in Spark SQL which is just a type alias of
`Dataset[Row]` -- see
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/package.scala#L46.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
