Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17434#discussion_r108634808 --- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java --- @@ -60,8 +60,6 @@ protected long getUsed() { /** * Force spill during building. - * --- End diff -- It's not "for testing only". I'd even say that it's more often used in a non-test code than test code. That made the comment no longer correct. See `ShuffleExternalSorter` and `UnsafeShuffleWriter` which both are `ShuffleWriter` instances.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org