Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/17610
bq. I don't get it. But I think the stack trace shows why this dead-lock
happens.
Based on your description/stacktrace, I get why the deadlock happens - what
I meant was, do any of the super.* methods invoked in the `stop` call tree
assume they are invoked with `this` already locked ?
If not, then a narrow lock on `this` just to flip the state of `stopped`
might be better. An `AtomicBoolean` will introduce a new lock (which is not
required here I think).
The deadlock occurs because we are calling rpc with the lock held already
(which is probably be a pattern we should somehow catch since it will
invariably cause deadlocks !)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
